I was asked off-list why I'm not suggesting we remove support for the
environment variable entirely (ie why keep it for tests). That's a good
question, so I will attempt to address it.
I think that's a laudable goal, but it's more work. Practically
speaking, AIUI valgrind still runs with e10s disabled [0], as does gtest
[1], some xpcshell tests but not others [2], and we run some mochitest
stuff in both configurations. There might be others.
I think it's valuable to migrate all of those to e10s, or stop reading
it, but I believe it may take some time, while I also think that we
should get rid of the user footgun ASAP.
Blanket-disabling all the non-e10s tests feels like a separate decision;
I assume we are unwilling to lose valgrind coverage, some portions of
gtest, and I don't know what else would break. I'd be happy to explore
that in the 80 cycle if others agree that's worth doing, though I am
probably not the best person to try to fix our valgrind/gtest stuff...
[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1549856
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1552140
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1568333
On 10/06/2020 19:30, Gijs Kruitbosch wrote:
(Copied to fx-dev; Replies to dev-platform please.)
Hello,
Just over a year ago, I started a discussion[0] about our support for
disabling e10s. The outcome of that was that we removed support for
disabling e10s with a pref on Desktop Firefox with version 68, except
for use from automation. We kept support for using the environment
variable. [1]
Last week, we released Firefox 77, which turned out to break all
webpages sent using compression (like gzip) if you had disabled e10s
using this environment variable. [2]
So here we are again. I'd like to propose we also stop honouring the
environment variable unless we're running tests in automation. We
clearly do not have sufficient test coverage to guarantee basic things
like "the browser works", it lacks security sandboxing, and a number of
other projects require it (fission, gpu process, socket process, ...),
so I think it's time to stop supporting this configuration at all.
I hope to make this change for the 79 cycle. I'm open to arguments
either way about what to do for 78 esr (assuming the patch for 79 turns
out to be simple; the work to remove the pref had a number of annoying
corner-cases at the time).
Please speak up if you think that this plan needs adjusting.
~ Gijs
[0]
https://groups.google.com/d/msg/mozilla.dev.platform/cJMzxi7_PmI/Pi1IOg_wCQAJ
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1548941
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1638652
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
