On 10-08-16 9:47 AM, David Humphrey wrote: > Hi #static (plus others who talk to me about DXR), > > I've put up a bunch of UI changes on http://dxr.mozilla.org for which > I'd like some feedback. Here's a good example file to try: > > http://dxr.mozilla.org/mozilla-central/netwerk/protocol/data/nsDataHandler.cpp.html#136/nsIChannel > > > or, to see a file with a warning: > > http://dxr.mozilla.org/mozilla-central/content/svg/content/src/nsSVGElement.cpp.html#l1281 > > > Things to note: > > * Sidebar will attempt to stay in sync with where your mouse is > pointing. That is, if you're pointing to a line in Foo(), it will show > you that
Like bsmedberg, I don't like this change very much. I think the sidebar highlight on hover doesn't really give me any useful information (given the new signature indicator pane). > * A new signature indicator at the top of the source will attempt to > show you the signature and line location for the function you're hovering. I like it very much. But I wonder why the typenames in that pane are not clickable? > * The info popup has been replaced with an expandable inline div, which > will show you info in a tree view. One question I have about the tree > is how deep you'd want to go with it (e.g., should clicking on a derived > type take you to a search, or load more data into the tree and let you > keep going?). I didn't like the popup that much, and I don't think that the new expandable div is much better than that. First of all, the animation, as cool as it is the first few times) starts to get annoying pretty quickly. It's true that we have to wait a short while before the data is loaded for the first time, but after that, when the data is cached, why should we keep people waiting a few hundred milliseconds to get their hands on the data they requested? One thing that has been impossible so far is to have multiple panes of type information open at the same time. For example, while I'm looking at nsIChannel, I may wonder what nsDataChannel is. Clicking it will cause the nsIChannel pane, which makes me go back and forth between the two panes. What I'm envisioning is another pane (at the right side of the screen for example) which is a central place for the type information panes, so that when I click a new type name, a section for that type is appended to that pane (if not already there) and expanded, with the previously opened sections remaining there until I manually close them. One other annoyance is that when you click a link in the opened pane (to see a function's implementation for example), the navigation happens in the original page (the fact that clicking Back just works right is a relief though!) And like bsmedberg said, we should really make those links middle-clickable, so that the opened page doesn't depend on the file originally being viewed. Thanks, and keep up the good work! Ehsan _______________________________________________ dev-static-analysis mailing list [email protected] https://lists.mozilla.org/listinfo/dev-static-analysis
