On 08/16/2010 06:47 AM, David Humphrey wrote:
Hi #static (plus others who talk to me about DXR),
I've put up a bunch of UI changes on http://dxr.mozilla.org for which
I'd like some feedback. Here's a good example file to try:
http://dxr.mozilla.org/mozilla-central/netwerk/protocol/data/nsDataHandler.cpp.html#136/nsIChannel
or, to see a file with a warning:
http://dxr.mozilla.org/mozilla-central/content/svg/content/src/nsSVGElement.cpp.html#l1281
This looks awesome! Just needs a few minor UI touchups.
Things to note:
* Sidebar will attempt to stay in sync with where your mouse is
pointing. That is, if you're pointing to a line in Foo(), it will show
you that
I am to blame for this feature request. This is more aggressive than I
envisioned. I was hoping for a simple scrollback sync. So when you
scroll somewhere in the code, the sidebar is synced-up to show the
relevant function. I'm thinking of a clippy-like popup UI on the side of
the page with misc context info.
* A new signature indicator at the top of the source will attempt to
show you the signature and line location for the function you're hovering.
I think this should be made into a formal popup(with smaller text +
minimize buttons) to make it clear that it's not inline.
* The info popup has been replaced with an expandable inline div, which
will show you info in a tree view. One question I have about the tree is
how deep you'd want to go with it (e.g., should clicking on a derived
type take you to a search, or load more data into the tree and let you
keep going?).
This is hot. As Benjamin said this needs to be appropriately sized. All
of the info in there should be hyperlinked(so it can be middleclicked).
While at it, can we have the sidebar autosize too?
I'm with Ehsan in that I'd rather have multiple persistent inlines(with
a close+closeall option).
* You close the info div by clicking a line outside it
I'm mostly interested in comments on the UI vs. notes about the data it
presents (I've got a list of known bugs for data that's wrong or
missing, and most of them are fixed by a handful of changes I have
underway).
I get conflicting advice from people about how this should look and
work, and I've tried to synthesize it all; I'm sure it can be improved
still.
What do you like and not want changed? What else should it do? How could
it be improved?
With the latest changes DXR screams "make it fullscreen". Unfortunately
the huge amount of space wasted on powered by moz + search hinders that.
I would be very happy with a non-inline box in top right of the screen
with search in it. I think most dxr users search via urlbar of their
browser, so the search box doesn't need to be too prominent when
displaying files.
Alternatively we could put some useful stuff on the top line of the
file(ie summary of the warning count, bugs open, blame link, etc) to go
with the searchbox.
Taras
PS. I disagree with Ehsan regarding animations. A little animation can
reduce disorientation.
_______________________________________________
dev-static-analysis mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-static-analysis
