Patches converting most of js/src have landed and the style guide has been updated. I'll post patches for the few remaining directories and XPConnect this week.
Don't worry too much about fixing up in-flight patches; I'll run the script again in a few days. Thanks, Jan On Wed, Sep 5, 2018 at 7:18 PM, Jeff Walden <jwalden+...@mit.edu> wrote: > On 09/05/2018 02:29 AM, Benjamin Bouvier wrote: > > I don't buy Jeff's argument at all; in the case of the (in)famous Apple > SSL > > bug, there *was* proper indentation and missing braces on the if, and > > though this wasn't enough to catch the failure. > > *Having* the rule is not the same as *enforcing* it by linter (or that > compiler option), and I meant enforcing the rule, not merely stating it and > seeing what happens. > > GCC/clang limitations don't amount to much, either, IMO. It isn't *that* > hard to write a fairly dumb checker-script to enforce indentation rules. > GCC and clang are not a serious limit here, and we could fix them if it > came to it. > > Jeff > _______________________________________________ > dev-tech-js-engine-internals mailing list > dev-tech-js-engine-internals@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals > _______________________________________________ dev-tech-js-engine-internals mailing list dev-tech-js-engine-internals@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
