On 2008.12.21., at 9:17, Cameron McCormack wrote:
Hi Rhino developers.
I've just filed a couple of bugs with patches (469937 and 470631), and
wanted to know what the procedure is to get them reviewed and
committed.
I set the review flag to "?" on the attachments,
That's a good idea overall.
but didn't fill in
anyone in the "Requestee" box. Should I list someone there
specifically?
470631 looks like Norris' turf, but I've just reviewed it (before
seeing this email, BTW, so not prodded by it) and it looks to me as if
it's consistent with the ECMA spec - these operators indeed always
return numbers. I'd like Norris to give his opinion too, but 470631
looks okay to me. I'll provisionally commit it, and Norris can back it
out if it's not okay, but I don't expect it'll be the case.
As for 469937, I created a unit test for it now, and it did indeed
fail before the patch, and passes after the patch, and doesn't seem to
break any other tests, so I'm committing it too.
All commits went to CVS HEAD, which'll end up being 1.7R3, if that's
okay with you. We have a 1.7R2 patch branch as well; would you need it
there too?
In any case, thank you very much for both of these patches - they're
quite valuable.
Attila.
--
home: http://www.szegedi.org
twitter: http://twitter.com/szegedi
weblog: http://constc.blogspot.com
_______________________________________________
dev-tech-js-engine-rhino mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-js-engine-rhino
