On Friday 2013-02-15 21:11 +1300, Robert O'Callahan wrote: > On Fri, Feb 15, 2013 at 6:59 PM, L. David Baron <[email protected]> wrote: > > > So I was just using sed to write a (long-overdue) patch to rename > > nsIFrame::GetStyleContext to nsIFrame::StyleContext to follow our > > convention that getters that can't return null don't have "Get" in > > the name. > > > > While I was doing that, it occurred to me that perhaps, instead of > > nsIFrame::StyleContext(), it should just be nsIFrame::Style(). > > > > They sound about the same level of goodness to me.
I'll probably stick with StyleContext(), since I already have the patch to do that, and it's more familiar to people. > Are you going to rename GetStyleBackground as well? That's the plan, but maybe not right now; it's probably a rather larger patch. > To StyleBackground() or BackgroundStyle()? I hadn't thought about it yet, but probably just dropping the "Get" is simpler both in terms of function/type correspondence and people's existing expectations. -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
