On Tuesday 2016-09-27 18:54 +0100, James Graham wrote: > On 27/09/16 18:36, Jet Villegas wrote: > >This proposed resolution affects Gecko and Servo. Please review and comment. > > FWIW we (well Ms2ger and I) have been heavily pushing for this change for > some time now; it considerably simplifies many things for us. For example > with the change it will be possible for both Gecko and Servo hackers to > contribute to the CSS testsuite with the same process that already works for > web-platform-tests. In Gecko it will also make it easy to have an > upd-to-date copy of the CSS tests in tree (my understanding is that the > current import is some years out of date). > > For gecko specifically there might be some concerns with running the entire > CSS testsuite through the wptrunner harness, as performance that is good > enough with 500 reftests might be deemed less acceptable with 10,000. > However I think this is something we can benchmark and optimise post-merge. > Certainly I don't think it's a reason not to go ahead with this change, > which will have the extremely positive effect of making the CSS testsuite > something we can both use an contribute to without significant manual > burden.
I'd like to see us run the reftests with our existing reftest
harness, which is optimized to do image comparison in compiled code,
and which also has a bunch of useful failure-annotation features [1]
and features that test for other sorts of failures such as
NS_ASSERTIONs.
(We should probably run them at the smaller screen resolution
mandated by the test suite rather than the 800x1000 that we really
ought to switch away from, though.)
-David
[1] although I'd really like to improve fuzzy annotations per
https://bugzil.la/1252361
--
𝄞 L. David Baron http://dbaron.org/ 𝄂
𝄢 Mozilla https://www.mozilla.org/ 𝄂
Before I built a wall I'd ask to know
What I was walling in or walling out,
And to whom I was like to give offense.
- Robert Frost, Mending Wall (1914)
signature.asc
Description: PGP signature
_______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
