> On Jan. 22, 2014, 8:54 p.m., Mike Drob wrote:
> > src/server/src/main/java/org/apache/accumulo/server/Accumulo.java, line 213
> > <https://reviews.apache.org/r/17192/diff/1/?file=435500#file435500line213>
> >
> >     Should this be configurable?

It could be, but more configurable options are not necessarily useful for the 
user. The only time this would matter would be

* if the user knew that had such a flaky network / dns that they needed to 
allow more chances
* if the user knew they had such a stable dns set up that no retries are needed 
(but they still might misconfigure with the wrong host name)

The latter seems unlikely. For the former, I think it's past the cost/benefit 
of working in the face of failure. At some point the there has to be a 
threshold of preferring to fix the underlying problem.

Given the amount of complexity it would add (this method doesn't grab any 
configuration directly now, should the retry count be updateable via ZK or only 
static, etc), I don't think the knob is worth having.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17192/#review32537
-----------------------------------------------------------


On Jan. 22, 2014, 7:13 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17192/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 7:13 p.m.)
> 
> 
> Review request for accumulo and Bill Havanki.
> 
> 
> Bugs: ACCUMULO-2225
>     https://issues.apache.org/jira/browse/ACCUMULO-2225
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2225 handle IllegalArgumentExceptions from Hadoop on host lookup 
> failure.
>     
>     Looks for cases where we treat IOExceptions out of Hadoop specially, then 
> attempts to replicate for UnknownHostExceptions that have been wrapped in 
> IllegalArgumentExceptions.
> 
> 
> Diffs
> -----
> 
>   
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 
> e02c19785c373170b2b0d47266a6988adeec7e17 
>   src/server/src/main/java/org/apache/accumulo/server/Accumulo.java 
> 253962bca5f2573fdfa87b82e145938e190842ed 
>   
> src/server/src/main/java/org/apache/accumulo/server/master/tableOps/DeleteTable.java
>  1c4d4ad8af30350d93f6dcfe2291463a90c835d3 
>   
> src/server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java
>  29b8455a2dce5ecf2195d9704980e3e9749683f4 
>   
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java
>  c8d1ea0872564643342387373d85b5ac87a57540 
>   
> src/server/src/main/java/org/apache/accumulo/server/util/TabletOperations.java
>  4a39050a17f84293c52f09b62932be5b957c8a91 
> 
> Diff: https://reviews.apache.org/r/17192/diff/
> 
> 
> Testing
> -------
> 
> builds on both hadoop profiles. starting functional tests now in combination 
> with 17132
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>

Reply via email to