> On Jan. 22, 2014, 8:54 p.m., Mike Drob wrote:
> > src/server/src/main/java/org/apache/accumulo/server/Accumulo.java, line 280
> > <https://reviews.apache.org/r/17192/diff/1/?file=435500#file435500line280>
> >
> > Why not catch IllegalArgumentException separately?
>
> Sean Busbey wrote:
> One downside of catching it separately is duplication of code between the
> two cases. unlike the case in ACCUMULO-2213, we're already grabbing
> everything in this catch.
ex, presuming we're only trying to change the behavior for those IAE's that are
wrapping UHE:
try {
Method setSafeMode = dfs.getClass().getMethod("setSafeMode",
safeModeAction);
return (Boolean)setSafeMode.invoke(dfs, get);
} catch (IllegalArgumentException exception) {
/* Send the wrapped Unknown Host back as-is, so we can deal with it in
the same place as the others */
if (exception.getCause() instanceof UnknownHostException) {
throw exception;
} else {
throw new RuntimeException("cannot find method setSafeMode", ex);
}
} catch (Exception ex) {
throw new RuntimeException("cannot find method setSafeMode", ex);
}
or should it just re-throw all IAEs as-is? that would be much simpler.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17192/#review32537
-----------------------------------------------------------
On Jan. 22, 2014, 7:13 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17192/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 7:13 p.m.)
>
>
> Review request for accumulo and Bill Havanki.
>
>
> Bugs: ACCUMULO-2225
> https://issues.apache.org/jira/browse/ACCUMULO-2225
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2225 handle IllegalArgumentExceptions from Hadoop on host lookup
> failure.
>
> Looks for cases where we treat IOExceptions out of Hadoop specially, then
> attempts to replicate for UnknownHostExceptions that have been wrapped in
> IllegalArgumentExceptions.
>
>
> Diffs
> -----
>
>
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java
> e02c19785c373170b2b0d47266a6988adeec7e17
> src/server/src/main/java/org/apache/accumulo/server/Accumulo.java
> 253962bca5f2573fdfa87b82e145938e190842ed
>
> src/server/src/main/java/org/apache/accumulo/server/master/tableOps/DeleteTable.java
> 1c4d4ad8af30350d93f6dcfe2291463a90c835d3
>
> src/server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java
> 29b8455a2dce5ecf2195d9704980e3e9749683f4
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java
> c8d1ea0872564643342387373d85b5ac87a57540
>
> src/server/src/main/java/org/apache/accumulo/server/util/TabletOperations.java
> 4a39050a17f84293c52f09b62932be5b957c8a91
>
> Diff: https://reviews.apache.org/r/17192/diff/
>
>
> Testing
> -------
>
> builds on both hadoop profiles. starting functional tests now in combination
> with 17132
>
>
> Thanks,
>
> Sean Busbey
>
>
