> On Jan. 28, 2014, 11:26 a.m., kturner wrote: > > Ship It!
Testing on a cluster I discovered a problem - the Tablet constructor calls needsMajorCompaction at its end, and without the tablet / tablet config set in the TabletResourceManager by then, I get an NPE. So I'll have to try something different, but I think I have a good idea for it. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17426/#review32996 ----------------------------------------------------------- On Jan. 28, 2014, 7:47 a.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17426/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 7:47 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1948 > https://issues.apache.org/jira/browse/ACCUMULO-1948 > > > Repository: accumulo > > > Description > ------- > > Change in the construction of the cross-referencing between Tablet and > TabletResourceManager to avoid the Tablet constructor leaking this. > > > Diffs > ----- > > server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java > 40dfcf0fa1715fbb0ff69e78bdf8954146a36b20 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > 5c1f6ce5f95523ef16005902c99a8f974e9e2baf > > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java > e95843775c85ecf90a2b4c7afce91094381da450 > > server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/17426/diff/ > > > Testing > ------- > > Added unit test. Real cluster testing TBD. > > > Thanks, > > Bill Havanki > >
