-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17426/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 2:21 p.m.)
Review request for accumulo.
Changes
-------
Attempt #4, designed to avoid Keith's tablet unload/reload scenario.
1. The memory management code now uses the snapshot of tablet states (memory
reports) to locate a tablet to minor compact, instead of using the current
tablet states. This ensures that the same exact tablet available at the time of
evaluation for compaction is used for that compaction later. If the tablet was
unloaded and reloaded, the old report is still used, and the closed tablet will
halt the compaction as usual. (This change was needed regardless of this
ticket!)
2. The tablet reference was put back into the tablet state (memory report) so
that the correct (unloaded) tablet would be used in the unload/reload scenario.
This means that the getOnlineTablet() method I had added to TabletServer could
go away.
The easiest way to grok this review is probably to compare the original code
with this diff, instead of comparing diff #3 with it.
Bugs: ACCUMULO-1948
https://issues.apache.org/jira/browse/ACCUMULO-1948
Repository: accumulo
Description
-------
Change in the construction of the cross-referencing between Tablet and
TabletResourceManager to avoid the Tablet constructor leaking this.
Diffs (updated)
-----
server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436
server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java
5ea2401acc720c70d58ee04c2dd82dc79fcf2b99
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
9d08c81f9b07a8c5f8a281769fd2914f5c8fc82b
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
e95843775c85ecf90a2b4c7afce91094381da450
server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/17426/diff/
Testing
-------
Added unit test. Real cluster testing TBD.
Thanks,
Bill Havanki
