----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19804/#review39056 -----------------------------------------------------------
server/src/main/java/org/apache/accumulo/server/Accumulo.java <https://reviews.apache.org/r/19804/#comment71442> Testability: avoid HdfsZooInstance.getInstance(), maybe have instance passed in to method? - Bill Havanki On March 28, 2014, 5:22 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19804/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 5:22 p.m.) > > > Review request for accumulo and kturner. > > > Bugs: ACCUMULO-2519 > https://issues.apache.org/jira/browse/ACCUMULO-2519 > > > Repository: accumulo > > > Description > ------- > > Adds "make sure Fate has no outstanding items" to the upgrade instructions. > Makes sure the master and tabletservers don't take upgrade steps if they see > fate ops waiting. > > > Diffs > ----- > > README 115a9b7 > server/src/main/java/org/apache/accumulo/server/Accumulo.java 99ec7e4 > server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864 > > server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java > d76946d > > Diff: https://reviews.apache.org/r/19804/diff/ > > > Testing > ------- > > Took a 1.4.5-SNAP cluster > > * triggered compactions > * shutdown cluster > * verified waiting transactions > * verified waiting local WALs > * verified /accumulo/version showed 4 > * Start upgrade to 1.5.2-SNAP > * verified errors showing no upgrade and to go back to docs in: monitor, > master logs, tabletserver logs > * verified waiting transactions > * verified waiting local WALs > * verified /accumulo/version showed 4 > * Cleared Fate operations > * Start upgrade to 1.5.2-SNAP > * verify no errors shown for upgrade > * verified WALs copied to HDFS > * verified /accumulo/version showed 5 > * verified monitor showed normal start up > > Running verify job on existing data now. should take ~6 hours. > > > Thanks, > > Sean Busbey > >