> On March 31, 2014, 4:33 p.m., Bill Havanki wrote: > > server/src/main/java/org/apache/accumulo/server/Accumulo.java, line 283 > > <https://reviews.apache.org/r/19804/diff/1/?file=539925#file539925line283> > > > > Testability: avoid HdfsZooInstance.getInstance(), maybe have instance > > passed in to method? > > Sean Busbey wrote: > I'd rather not muck with the testability of the extant fate stuff as a > part of making upgrades work. > > Mike Drob wrote: > This whole method being static doesn't sit well with me. I think I would > be much happier if it returned a boolean instead of throwing an exception, > too.
It doesn't throw an exception, it exits. the internal exception is to limit the exit handling and logging to a single location, because the transaction store can throw a couple of exceptions. If those happen we also need to exit. Returning a boolean would mean adding logging and exit calls in both places this method gets called. What would be the upside? - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19804/#review39056 ----------------------------------------------------------- On April 2, 2014, 6:06 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19804/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 6:06 a.m.) > > > Review request for accumulo and kturner. > > > Bugs: ACCUMULO-2519 > https://issues.apache.org/jira/browse/ACCUMULO-2519 > > > Repository: accumulo > > > Description > ------- > > Adds "make sure Fate has no outstanding items" to the upgrade instructions. > Makes sure the master and tabletservers don't take upgrade steps if they see > fate ops waiting. > > > Diffs > ----- > > README 115a9b7 > server/src/main/java/org/apache/accumulo/server/Accumulo.java 99ec7e4 > server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864 > > server/src/main/java/org/apache/accumulo/server/tabletserver/TabletServer.java > d76946d > server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java > 7328a55 > > Diff: https://reviews.apache.org/r/19804/diff/ > > > Testing > ------- > > Took a 1.4.5-SNAP cluster > > * loaded test data in a variety of table configs > * alternate table creation and deletion > * load additional table to cause !METADATA churn > * shutdown cluster uncleanly > * verified waiting Fate transactions (table deletion at success status) > * verified waiting local WALs > * verified waiting local WALs include !METADATA table (via LogReader) > * verified /accumulo/version showed 4 > * Start upgrade to 1.5.2-SNAP > * verified errors showing no upgrade and to go back to docs in: monitor, > master logs, tabletserver logs > * verified same waiting Fate transactions > * verified same waiting local WALs > * verified /accumulo/version showed 4 > * Cleared Fate operations > * Start upgrade to 1.5.2-SNAP > * wait a terrifying long amount of time, check on progress via local logs > * verify no errors shown for upgrade > * verified WALs copied to HDFS > * verified /accumulo/version showed 5 > * verified monitor showed normal start up > * wait for all tablets to be hosted > * verify test data > > > Thanks, > > Sean Busbey > >
