> On April 17, 2014, 5:21 p.m., Vikram Srivastava wrote: > > We should also test that using the new Appender works fine and daemons are > > able to send logs to Monitor. Should we add a MacIT for that? > > > > Also, should we update the example log configuration files to use the new > > Appender? > > Sean Busbey wrote: > an IT that makes use of this would be a good addition.
Updating the examples could be done either here or for ACCUMULO-2383. I'm fine either way with it. Depends on how we'd like to meter out the work. I'll look into an IT for it. That could be a good substitute for my (shameful ;) ;) ) main method. > On April 17, 2014, 5:21 p.m., Vikram Srivastava wrote: > > core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java, > > line 119 > > <https://reviews.apache.org/r/20465/diff/1/?file=561771#file561771line119> > > > > Is it normal to add test main methods to classes like this? > > Sean Busbey wrote: > it's a bad habit, but one the Accumulo code base already has. Indeed, I felt OK leaving it in since it's A Thing in Accumulo. Nevertheless, I have no problem removing it before commit. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20465/#review40697 ----------------------------------------------------------- On April 17, 2014, 5:06 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20465/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 5:06 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2343 > https://issues.apache.org/jira/browse/ACCUMULO-2343 > > > Repository: accumulo > > > Description > ------- > > AsyncSocketAppender is a Log4J AsyncAppender with its own internal > SocketAppender. Configuration for either appender can be set on the > AsyncSocketAppender itself. An AsyncSocketAppender can be configured using a > Log4J properties file, while an ordinary AsyncAppender cannot. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20465/diff/ > > > Testing > ------- > > Unit test created and passed. Also used main() method to send log messages to > a running Log4J SimpleSocketServer instance. > > > Thanks, > > Bill Havanki > >
