----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20465/#review40942 -----------------------------------------------------------
Did you also verify that you can run an instance using only the log4j.properties? Perhaps wrapping back around to earlier comments, have you also verified that updates to log4j.properties reload the logging backend? I'm not sure if log4j configures and watches log4j.properties by default. Also, what happens if I have both *_logger.xml files and log4j.properties files on the classpath which conflict each other (one sets some logger to WARN and the other to DEBUG) -- which one will actually be set? test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java <https://reviews.apache.org/r/20465/#comment74265> Starting the Monitor before the cluster starts mind eliminate some churn. I forget if the tserver just has a watcher set to see the update or if it polls periodically. test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java <https://reviews.apache.org/r/20465/#comment74259> Would be better to actually look in zookeeper for when the monitor registers itself using a Watcher than just guessing that 10s is long enough. test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java <https://reviews.apache.org/r/20465/#comment74261> You can easily create a monitor entry by trying to scan a table with a SKVI of "java.lang.String" or something of the sort. It would be good to ensure that you generated a message before checking. - Josh Elser On April 18, 2014, 7:14 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20465/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 7:14 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-2343 > https://issues.apache.org/jira/browse/ACCUMULO-2343 > > > Repository: accumulo > > > Description > ------- > > AsyncSocketAppender is a Log4J AsyncAppender with its own internal > SocketAppender. Configuration for either appender can be set on the > AsyncSocketAppender itself. An AsyncSocketAppender can be configured using a > Log4J properties file, while an ordinary AsyncAppender cannot. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java > PRE-CREATION > > test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java > d9bed7f > > test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java > PRE-CREATION > test/src/test/resources/conf/generic_logger.xml PRE-CREATION > test/src/test/resources/conf/monitor_logger.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/20465/diff/ > > > Testing > ------- > > Unit test created and passed. Also used main() method to send log messages to > a running Log4J SimpleSocketServer instance. > > > Thanks, > > Bill Havanki > >
