> On April 21, 2014, 4:56 p.m., Josh Elser wrote: > > docs/src/main/resources/RB.md, line 73 > > <https://reviews.apache.org/r/20422/diff/2/?file=563069#file563069line73> > > > > It seems odd to me to specify rules for a "passing review" and duration > > length when they're not required. I think "use your best judgement" sums up > > most of these bullet points. > > Sean Busbey wrote: > I thought it already said that? Is your issue with the use of "required"?
I'll rephrase these items. I'm going from the perspective of setting required levels for yourself / your own reviews, e.g., "I am posting this review and I won't let myself say it's passed until I get two 'Ship It's." I can see that as maybe a bit odd. :) - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40940 ----------------------------------------------------------- On April 21, 2014, 10:50 a.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20422/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 10:50 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1834 > https://issues.apache.org/jira/browse/ACCUMULO-1834 > > > Repository: accumulo > > > Description > ------- > > A proposed set of guidelines for using Review Board, in deference to our > recently-approved and improved bylaws. > > > Diffs > ----- > > docs/src/main/resources/RB.md PRE-CREATION > > Diff: https://reviews.apache.org/r/20422/diff/ > > > Testing > ------- > > > Thanks, > > Bill Havanki > >