----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22308/#review44918 -----------------------------------------------------------
Ship it! fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java <https://reviews.apache.org/r/22308/#comment79500> Throw a @VisibleForTesting on here? fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java <https://reviews.apache.org/r/22308/#comment79510> Should the verify be after the cache hit to make sure the zk code didn't get called multiple times? Not sure. - Mike Drob On June 6, 2014, 4:36 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22308/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 4:36 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2865 > https://issues.apache.org/jira/browse/ACCUMULO-2865 > > > Repository: accumulo > > > Description > ------- > > This adds a unit test for ZooCache. ZooCache itself was only changed > slightly, with the addition of methods to check if information was cached and > improvements to its comments. > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java 99ffd04 > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22308/diff/ > > > Testing > ------- > > Unit tests pass, including ZooCacheTest. > > > Thanks, > > Bill Havanki > >
