> On June 6, 2014, 12:59 p.m., Eric Newton wrote: > > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java, > > line 28 > > <https://reviews.apache.org/r/22308/diff/1/?file=604767#file604767line28> > > > > The style guide calls for imports without wildcards.
You're right. I'll expand it on commit. > On June 6, 2014, 12:59 p.m., Eric Newton wrote: > > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java, > > line 41 > > <https://reviews.apache.org/r/22308/diff/1/?file=604767#file604767line41> > > > > The rest of the codebase puts tags on their own line. True, I had forgotten to format the file before posting it. After formatting, the annotation is on a separate line. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22308/#review44919 ----------------------------------------------------------- On June 6, 2014, 12:36 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22308/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 12:36 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2865 > https://issues.apache.org/jira/browse/ACCUMULO-2865 > > > Repository: accumulo > > > Description > ------- > > This adds a unit test for ZooCache. ZooCache itself was only changed > slightly, with the addition of methods to check if information was cached and > improvements to its comments. > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java 99ffd04 > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22308/diff/ > > > Testing > ------- > > Unit tests pass, including ZooCacheTest. > > > Thanks, > > Bill Havanki > >
