> On July 25, 2014, 3:20 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java, > > line 106 > > <https://reviews.apache.org/r/23887/diff/3/?file=642002#file642002line106> > > > > Can we call this SanityCheckException? > > > > (CheckException is too generic, and intuitively seems to have something > > to do with "checked exceptions", which isn't the case.)
Yes, I like your name better. I'll do that for this patch and the 1.5 one as well. (I originally had ConfigSanityCheckException but figured that was too long!) - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23887/#review48757 ----------------------------------------------------------- On July 25, 2014, 1:08 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23887/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 1:08 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3012 > https://issues.apache.org/jira/browse/ACCUMULO-3012 > > > Repository: accumulo > > > Description > ------- > > * The internal map of resolved (default) properties is now static and > immutable, making explicit synchronization unnecessary. > * The main method is moved to ConfigurationDocGen. > * A unit test is added. > * Accompanying changes were made to ConfigSanityCheck: > - The validate method takes in an Iterable of entries instead of a > Configuration. > - Validation failure throws a new CheckException class instead of > RuntimeException. > - A unit test is added. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java > f9781f4 > core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java > ca57372 > core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java > 44e198a > core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java > PRE-CREATION > > core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java > PRE-CREATION > docs/pom.xml d54b144 > > Diff: https://reviews.apache.org/r/23887/diff/ > > > Testing > ------- > > Compiles, unit tests pass, no new findbugs / PMD issues. > > > Thanks, > > Bill Havanki > >
