-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23887/
-----------------------------------------------------------
(Updated July 25, 2014, 3:50 p.m.)
Review request for accumulo.
Changes
-------
D'oh! Missed a Javadoc change in the last diff.
Bugs: ACCUMULO-3012
https://issues.apache.org/jira/browse/ACCUMULO-3012
Repository: accumulo
Description
-------
* The internal map of resolved (default) properties is now static and
immutable, making explicit synchronization unnecessary.
* The main method is moved to ConfigurationDocGen.
* A unit test is added.
* Accompanying changes were made to ConfigSanityCheck:
- The validate method takes in an Iterable of entries instead of a
Configuration.
- Validation failure throws a new CheckException class instead of
RuntimeException.
- A unit test is added.
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java
f9781f4
core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java
ca57372
core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java
44e198a
core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java
PRE-CREATION
core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java
PRE-CREATION
docs/pom.xml d54b144
Diff: https://reviews.apache.org/r/23887/diff/
Testing
-------
Compiles, unit tests pass, no new findbugs / PMD issues.
Thanks,
Bill Havanki
