Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/16#discussion_r18100257
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java
---
@@ -16,14 +16,65 @@
*/
package org.apache.accumulo.server.fs;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
import java.util.Random;
+import org.apache.accumulo.core.conf.AccumuloConfiguration.AllFilter;
+import org.apache.accumulo.core.conf.AccumuloConfiguration.PropertyFilter;
+import org.apache.log4j.Logger;
+
public class RandomVolumeChooser implements VolumeChooser {
+ private static final Logger log =
Logger.getLogger(RandomVolumeChooser.class);
Random random = new Random();
-
+
+ public RandomVolumeChooser() {}
--- End diff --
Oh, I see. Yeah, I agree. The RandomVolumeChooser shouldn't change much.
The preferredVolumes stuff should be rolled into the StaticVolumeChooser, since
the static case is just a special case (only one preference). (And the
StaticVolumeChooser should probably be renamed, and moved to examples, since it
depends on custom user properties.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
