Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/16#discussion_r18100611
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java ---
@@ -18,5 +18,7 @@
public interface VolumeChooser {
+ String choose(VolumeChooserEnvironment env, String[] options);
--- End diff --
Right, this will break the interface. This is low risk, I think, though.
The VolumeChooser isn't part of the public API (yet), is it? The alternative is
that we can pass the environment with dependency injection to an annotated
field, if it exists. If this is something that's a blocker, that's an option.
There's also a slight behavioral change to consider here (improvement, I
think) that may be relevant, if we're concerned about API. The original
VolumeChooser interface did not choose between volumes.... it chose between
paths. This patch changes things so that the API conforms to the user
expectations that it will be provided with volumes from which to choose, which
the framework will append any necessary paths to, if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
