I'm not worried about this Jenkins job. I doubt this will introduce significant spam. I'm more worried about the spam from comments on pull requests/reviews on pull requests that might discourage pull requests in general, and reduce the likelihood of this Jenkins job getting much use. But, that's a separate thread. :)
-- Christopher L Tubbs II http://gravatar.com/ctubbsii On Thu, Oct 2, 2014 at 7:18 PM, Josh Elser <josh.el...@gmail.com> wrote: > Ok, that works for me. I forgot that the compile-plugin would help out. > > Yeah, I mostly added it because I wanted to get a feel for what the > interaction feels like. If it's spammy or not adding much value, we can > turn it off. > > > Christopher wrote: > >> Nah, the maven-compiler-plugin configuration passes -source 1.6 -target >> 1.6 >> to javac, which will catch 99% of that. There's a few compile-time type >> safety stuff with generics that it won't catch, but these are fringe cases >> that are easily caught and fixed, so I don't think it's worth having two >> jobs for. >> >> >> And, no problem. Thanks for adding this! Seems like it will be useful. >> Though, I think we still need to decide how much pull-request spam we want >> to deal with. >> >> >> -- >> Christopher L Tubbs II >> http://gravatar.com/ctubbsii >> >> On Thu, Oct 2, 2014 at 6:50 PM, Josh Elser<josh.el...@gmail.com> wrote: >> >> Should we have a JDK 1.6 build against the 1.6 branch to catch things >>> like >>> JDK7 only constructs? I'm not entirely sure if that's possible with the >>> new >>> plugin or not. >>> >>> >>> Christopher wrote: >>> >>> I bumped the JDK version to 1.7, so pull requests against master work, >>>> and >>>> I made it use Maven 3.2.1, so we benefit from performance and bugfixes >>>> in >>>> the latest maven, and to protect against future changes that might >>>> require >>>> a newer maven. >>>> >>>> I also changed the name to "Accumulo-Pull-Requests" to eliminate the >>>> spaces >>>> in the URL, so it is now: >>>> https://builds.apache.org/job/Accumulo-Pull-Requests/ >>>> >>>> Incidentally, this rename makes it show up correctly under: >>>> https://builds.apache.org/view/A-D/view/Accumulo/ >>>> >>>> >>>> -- >>>> Christopher L Tubbs II >>>> http://gravatar.com/ctubbsii >>>> >>>> On Thu, Oct 2, 2014 at 3:14 PM, Josh Elser<josh.el...@gmail.com> >>>> wrote: >>>> >>>> FYI, I just enabled a new Jenkins job that should see any >>>> pull-requests >>>> >>>>> opened against http://github.com/apache/accumulo, build it, and share >>>>> the >>>>> results. >>>>> >>>>> * https://builds.apache.org/job/Accumulo%20Pull%20Requests/ >>>>> * https://blogs.apache.org/infra/entry/github_pull_request_builds_now >>>>> >>>>> Feel free to make any other changes to the job that make sense. I left >>>>> most of the defaults from the regular hourly-polling job. >>>>> >>>>> - Josh >>>>> >>>>> >>>>> >>
