> On Feb. 24, 2016, 8:43 p.m., Christopher Tubbs wrote: > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java, > > line 227 > > <https://reviews.apache.org/r/43957/diff/1/?file=1268376#file1268376line227> > > > > Isn't there a race condition here without the synchronized block? Does > > it matter?
Hang on. I ripped the band-aid off and started removing synchronized modifiers. Should have an updated patch here soon. - Dave ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43957/#review120575 ----------------------------------------------------------- On Feb. 24, 2016, 7:29 p.m., Dave Marion wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43957/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 7:29 p.m.) > > > Review request for accumulo and Josh Elser. > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-1755: removed synchronized modifier from > TabletServerBatchWriterstartProcessing() > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > bc90d00 > > Diff: https://reviews.apache.org/r/43957/diff/ > > > Testing > ------- > > unit tests in core pass > > > Thanks, > > Dave Marion > >
