----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43957/#review120584 -----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java (line 240) <https://reviews.apache.org/r/43957/#comment182056> Removing this synchronized will make it tough to keep the MutationSet limited to a given size. There's now the possibility that every thread can now add a mutation before the aggregate size of mutations gets checked. Also, startProcessing() can get called once per thread every time the buffer fills instead of just once. Synchronizing this method is probably not a huge performance problem if we limit the operations to adding references to a list and a quick size check. Maybe we can have startProcessing() return a Runnable that then gets executed outside of a synchronized block in addMutation? - Adam Fuchs On Feb. 24, 2016, 11:10 p.m., Dave Marion wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43957/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:10 p.m.) > > > Review request for accumulo and Josh Elser. > > > Bugs: ACCUMULO-1755 > https://issues.apache.org/jira/browse/ACCUMULO-1755 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-1755: removed synchronized modifier from > TabletServerBatchWriterstartProcessing() > > > Diffs > ----- > > > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java > bc90d00 > > Diff: https://reviews.apache.org/r/43957/diff/ > > > Testing > ------- > > unit tests in core pass > > > Thanks, > > Dave Marion > >
