My understanding was that you don't need the "developed at the Apache
Software Foundation" line, but the copyright line was still necessary.
http://www.apache.org/dev/licensing-howto.html#bundle-asf-product
However, I forget about LEGAL-234. It looks like we just dropped the
ball to correct both our NOTICE files and the "licensing howto"
documentation. Thanks for reminding me, Christopher.
This changes my -1 to a +1 (binding). Let's also get issues filed to fix
this stuff before the next release (to avoid this one again).
Mike Drob wrote:
Ah, I didn't see this response while composing my other one. A similar
question then, Christopher. Do we need to remove all the individual project
lines?
On Mon, Jun 20, 2016 at 11:31 AM, Christopher<[email protected]> wrote:
On Sun, Jun 19, 2016 at 9:26 PM Josh Elser<[email protected]> wrote:
-1 (binding)
HTrace's NOTICE is missing in -bin's NOTICE file
"""
htrace-core
Copyright 2015 The Apache Software Foundation
"""
The NOTICE file should not have entries for other ASF-copyrighted
materials. The ones that are there already should not be there. This was
discussed on https://issues.apache.org/jira/browse/LEGAL-234 with the
conclusion that these were superfluous and the NOTICE could be simplified
by omitting these. The fact that these aren't necessary, and the general
instructions to omit anything that isn't legally required (
http://www.apache.org/dev/licensing-howto.html#mod-notice), means these
shouldn't be there.
I provide this information in case it changes your vote.
The good:
* Can run with bin tarball out of the box. Simple write/read/update/read
works in the shell.
* `mvn verify -Psunny` passes on src tarball
* xsums/sigs are fine.
* Good on you using the long-form keyid
* Verified no Thrift changes (accounting for the !thrift)
* Verified no changes to public API code (to avoid running japi)
Sorry, Mike. Wish I could've caught this one on rc1.
- Josh
Mike Drob wrote:
Accumulo Developers,
Please consider the following candidate for Accumulo 1.7.2.
All content generated via
assemble/build.sh --create-release-candidate -P '!thrift'
Changes from 1.7.2-rc1
ACCUMULO-4346 correct LICENSE file for source to include text of
reference
ACCUMULO-4347 Crypto notification should be in README files instead of
NOTICE
Git Commit:
a01e67741d101c3d87f1d6e16d54ff7a96951ad0
Branch:
1.7.2-rc2
If this vote passes, a gpg-signed tag will be created using:
git tag -f -m 'Apache Accumulo 1.7.2' -s rel/1.7.2
a01e67741d101c3d87f1d6e16d54ff7a96951ad0
Staging repo:
https://repository.apache.org/content/repositories/orgapacheaccumulo-1052
Source (official release artifact):
https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/org/apache/accumulo/accumulo/1.7.2/accumulo-1.7.2-src.tar.gz
Binary:
https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/org/apache/accumulo/accumulo/1.7.2/accumulo-1.7.2-bin.tar.gz
(Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
given artifact.)
All artifacts were built and staged with:
mvn release:prepare&& mvn release:perform
Signing keys are available at
https://www.apache.org/dist/accumulo/KEYS
(Expected fingerprint: 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E)
Release notes (in progress) can be found at:
https://accumulo.apache.org/release_notes/1.7.2
Please vote one of:
[ ] +1 - I have verified and accept...
[ ] +0 - I have reservations, but not strong enough to vote against...
[ ] -1 - Because..., I do not accept...
... these artifacts as the 1.7.2 release of Apache Accumulo.
This vote will end on Tue Jun 21 05:00:00 UTC 2016
(Tue Jun 21 01:00:00 EDT 2016 / Mon Jun 20 22:00:00 PDT 2016)
Thanks!
P.S. Hint: download the whole staging repo with
wget -erobots=off -r -l inf -np -nH \
https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/
# note the trailing slash is needed