Christopher wrote:
+0 * Verified all hashes, sigs * Unit tests and ITs all pass (org.apache.accumulo.test.BadDeleteMarkersCreatedIT.test timed out the first time, but passed on re-run) * Verified contents of bin tarball match jars in staging repo and src tarball match rc branch in git My only concern would be that https://issues.apache.org/jira/browse/ACCUMULO-4317 was marked as a blocker, but was bumped. So, I'll hold my +1 until it's agreed whether that's actually a blocker and should be included in 1.7.2, or if it's not a blocker and okay to bump.
I'd encourage you to weigh in on how critical you think it is on the JIRA issue. It seems pretty bad to me that we fail like this, but as Mike rightfully points out, it isn't a new bug. We failed to get the patch applied and I think that looks sloppy on our part (I would hate for someone else to run into the same issue with a 1.7 and still have no release which contains the fix available).
It's on all of us to decide whether or not the severity of the issue, not just how I throw my weight around :)
On Sat, Jun 18, 2016 at 12:31 AM Mike Drob<[email protected]> wrote:Accumulo Developers, Please consider the following candidate for Accumulo 1.7.2. All content generated via assemble/build.sh --create-release-candidate -P '!thrift' Changes from 1.7.2-rc1 ACCUMULO-4346 correct LICENSE file for source to include text of reference ACCUMULO-4347 Crypto notification should be in README files instead of NOTICE Git Commit: a01e67741d101c3d87f1d6e16d54ff7a96951ad0 Branch: 1.7.2-rc2 If this vote passes, a gpg-signed tag will be created using: git tag -f -m 'Apache Accumulo 1.7.2' -s rel/1.7.2 a01e67741d101c3d87f1d6e16d54ff7a96951ad0 Staging repo: https://repository.apache.org/content/repositories/orgapacheaccumulo-1052 Source (official release artifact): https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/org/apache/accumulo/accumulo/1.7.2/accumulo-1.7.2-src.tar.gz Binary: https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/org/apache/accumulo/accumulo/1.7.2/accumulo-1.7.2-bin.tar.gz (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a given artifact.) All artifacts were built and staged with: mvn release:prepare&& mvn release:perform Signing keys are available at https://www.apache.org/dist/accumulo/KEYS (Expected fingerprint: 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E) Release notes (in progress) can be found at: https://accumulo.apache.org/release_notes/1.7.2 Please vote one of: [ ] +1 - I have verified and accept... [ ] +0 - I have reservations, but not strong enough to vote against... [ ] -1 - Because..., I do not accept... ... these artifacts as the 1.7.2 release of Apache Accumulo. This vote will end on Tue Jun 21 05:00:00 UTC 2016 (Tue Jun 21 01:00:00 EDT 2016 / Mon Jun 20 22:00:00 PDT 2016) Thanks! P.S. Hint: download the whole staging repo with wget -erobots=off -r -l inf -np -nH \ https://repository.apache.org/content/repositories/orgapacheaccumulo-1052/ # note the trailing slash is needed
