Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/224#discussion_r103819636
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java
---
@@ -209,4 +210,12 @@ public static void setSampler(Class<?>
implementingClass, Configuration conf, Sa
}
}
+ public static void setSummarizers(Class<?> implementingClass,
Configuration conf, SummarizerConfiguration[] sumarizerConfigs) {
+ Map<String,String> props =
SummarizerConfiguration.toTableProperties(sumarizerConfigs);
+
+ for (Entry<String,String> entry : props.entrySet()) {
+ conf.set(enumToConfKey(implementingClass, Opts.ACCUMULO_PROPERTIES)
+ "." + entry.getKey(), entry.getValue());
--- End diff --
I don't think this code is called frequently enough to justify
optimizations that would make the code longer/harder to read. Also the java
compiler will use StringBuilder when concatenating multiple strings. However,
I don't think it will reuse it across the loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
