Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r103819806
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java
 ---
    @@ -121,8 +128,22 @@ public NewTableConfiguration 
setProperties(Map<String,String> prop) {
        */
       public NewTableConfiguration enableSampling(SamplerConfiguration 
samplerConfiguration) {
         requireNonNull(samplerConfiguration);
    -    SamplerConfigurationImpl.checkDisjoint(properties, 
samplerConfiguration);
    -    this.samplerConfiguration = samplerConfiguration;
    +    Map<String,String> tmp = new 
SamplerConfigurationImpl(samplerConfiguration).toTablePropertiesMap();
    --- End diff --
    
    I don't think this would be called frequently enough for it to be worth it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to