Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/242#discussion_r110242657
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java
---
@@ -118,19 +98,17 @@ public void start() {
}
}
- public void stop() {
+ private void stop() {
--- End diff --
I was trying to clean up the embedded web server, and simplify its
abstraction around Jetty. We never call stop outside the method. I marked it
private to verify and left it that way. This is an internal class, so there's
no reason it should be public if it doesn't need to be. I would like to do
further refactoring and simplification of the Java portions of the monitor
service... but that can happen in a future task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
