Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110250805
  
    --- Diff: 
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java
 ---
    @@ -0,0 +1,204 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.monitor.rest.replication;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +
    +import javax.ws.rs.GET;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.core.MediaType;
    +
    +import org.apache.accumulo.core.client.AccumuloException;
    +import org.apache.accumulo.core.client.AccumuloSecurityException;
    +import org.apache.accumulo.core.client.BatchScanner;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.TableNotFoundException;
    +import org.apache.accumulo.core.client.TableOfflineException;
    +import org.apache.accumulo.core.client.admin.TableOperations;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Range;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.metadata.MetadataTable;
    +import org.apache.accumulo.core.metadata.RootTable;
    +import org.apache.accumulo.core.replication.ReplicationSchema.WorkSection;
    +import org.apache.accumulo.core.replication.ReplicationTable;
    +import org.apache.accumulo.core.replication.ReplicationTarget;
    +import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.monitor.Monitor;
    +import org.apache.accumulo.server.replication.ReplicaSystem;
    +import org.apache.accumulo.server.replication.ReplicaSystemFactory;
    +import org.apache.hadoop.io.Text;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + *
    + * Generates the replication table with information from the Monitor
    + *
    + * @since 2.0.0
    + *
    + */
    +@Path("/replication")
    +@Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML})
    --- End diff --
    
    It may still be possible to declare these on a base resource. However, I 
removed that in my PR to @lstav because it created a StackOverflowError while 
processing sub-resources on the parent class. It's possible it can be 
inherited, but I'm not sure if it inherits from a parent class/interface to a 
child class or if it inherits from a parent resource to sub-resources. Doing 
both causes problems, and I didn't try them individually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to