Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/279#discussion_r126503288
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java
---
@@ -26,7 +27,7 @@ private static String getTableName(Instance instance,
String tableId) {
if (tableId == null)
return " <unknown table> ";
try {
- String tableName = Tables.getTableName(instance, tableId);
+ String tableName = Tables.getTableName(instance, new
Table.ID(tableId));
--- End diff --
Could maybe avoid duplicates by making constructor private and doing
`Table.ID.of(tableId)`, which draws from an internal `WeakReference` map. I
think we do this in one place with table names. It's not necessary on a first
pass, but maybe something to think about if this object creation starts killing
performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
