Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129976474
  
    --- Diff: 
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java
 ---
    @@ -264,4 +264,12 @@ protected static void banner(StringBuilder sb, String 
klass, String text) {
         sb.append("<br />\n<h2 
class='").append(klass).append("'>").append(text).append("</h2>\n");
       }
     
    +  /**
    +   * Creates a {@link Cookie} with the given name and value, also setting 
the HttpOnly attribute on the cookie.
    +   */
    +  protected static Cookie createCookie(String name, String value) {
    +    Cookie c = new Cookie(name, value);
    +    c.setHttpOnly(true);
    --- End diff --
    
    > I can double-check, but I'm not aware of that in 1.x. Not sure how the 
table sorting stuff works.
    
    So I'm surprised, but this actually just doesn't break anything. Sorting on 
tables still works. Returning to a page after leaving retains the sort 
column+order.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to