Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/283#discussion_r129978175
--- Diff:
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java
---
@@ -264,4 +264,12 @@ protected static void banner(StringBuilder sb, String
klass, String text) {
sb.append("<br />\n<h2
class='").append(klass).append("'>").append(text).append("</h2>\n");
}
+ /**
+ * Creates a {@link Cookie} with the given name and value, also setting
the HttpOnly attribute on the cookie.
+ */
+ protected static Cookie createCookie(String name, String value) {
+ Cookie c = new Cookie(name, value);
+ c.setHttpOnly(true);
--- End diff --
We may only be using these server-side. Pretty sure we're refreshing the
page and getting the resorted version from the server. I just wasn't sure if
that was always the case, or if there was some fringe place where it would
break.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
