+1 for the split, will also improve testability and generally easy-on for new contributors
On Oct 1, 2012, at 8:13, Hiram Chirino <[email protected]> wrote: > Yeah. That's what I figure. I'm sure we can figure out a way to decouple > the two and still be able to embed broker if the broker jar is present. > > BTW: Having a separate client jar will also make it simpler to ship a JMS > client implementation with Apollo. Hell, if the way the broker is > 'embedded' is pluggable enough, perhaps we can get the JMS client to boot > Apollo as the embedded broker. > > On Mon, Oct 1, 2012 at 11:06 AM, Dejan Bosanac <[email protected]> wrote: > >> The problem with activemq-client is that we usually need to support >> embedded broker and that means all transports, stores and stuff. But >> that doesn't mean we can't create activemq-client, that only supports >> tcp transport which I guess 90% of folks use on the client side. >> >> >> Regards >> -- >> Dejan Bosanac >> ---------------------- >> Red Hat, Inc. >> FuseSource is now part of Red Hat >> [email protected] >> Twitter: @dejanb >> Blog: http://sensatic.net >> ActiveMQ in Action: http://www.manning.com/snyder/ >> >> >> On Mon, Oct 1, 2012 at 4:45 PM, Hiram Chirino <[email protected]> >> wrote: >>> On Mon, Oct 1, 2012 at 10:38 AM, Claus Ibsen <[email protected]> >> wrote: >>> >>>> +1 >>>> >>>> I think some of the transports could be moved into own modules as well. >>>> - mqtt >>>> - zeroconf >>>> >>>> And maybe the old kaha >>>> Or the dot generator; from the view package (wonder who uses it, or if >>>> its up to date) >>>> And the ftp blob suppor as well. For example you cant use file without >>>> having the ftp library on the classpath because they are in the same >>>> package. >>>> And I guess would be nice with spring xbean to be in own module as well. >>>> >>>> I guess I went a bit overboard with my "wish list" for AMQ core to be >>>> trimmed down. >>> totally aggree... and hell if we are going to be talking about wish >> lists, >>> here's one that sounds a little crazy: split activemq-core into a >>> activemq-client and activemq-broker module. But we probably need to >> first >>> trim down all the fat before we can tackle that :) >>> >>> >>> >>>> >>>> >>>> On Mon, Oct 1, 2012 at 4:18 PM, Hiram Chirino <[email protected]> >>>> wrote: >>>>> Considering how large the activemq-core module is, I was wondering if >> you >>>>> guys thought it might be beneficial to move the message stores into >> their >>>>> own modules. The leveldb store that is now integrated into the builds >>>>> gives us an example of how it can be done while still providing tight >>>>> integration /w XBean. The one down side I can think of is that users >> who >>>>> embed ActiveMQ would need to be aware of this change and update their >>>>> builds accordingly to avoid breaking. >>>>> >>>>> >>>>> -- >>>>> >>>>> ** >>>>> >>>>> *Hiram Chirino* >>>>> >>>>> *Engineering | Red Hat, Inc.* >>>>> >>>>> *[email protected] <[email protected]> | fusesource.com | >> redhat.com >>>> * >>>>> >>>>> *skype: hiramchirino | twitter: @hiramchirino< >>>> http://twitter.com/hiramchirino> >>>>> * >>>>> >>>>> *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>* >>>> >>>> >>>> >>>> -- >>>> Claus Ibsen >>>> ----------------- >>>> Red Hat, Inc. >>>> FuseSource is now part of Red Hat >>>> Email: [email protected] >>>> Web: http://fusesource.com >>>> Twitter: davsclaus >>>> Blog: http://davsclaus.com >>>> Author of Camel in Action: http://www.manning.com/ibsen >>> >>> >>> >>> -- >>> >>> ** >>> >>> *Hiram Chirino* >>> >>> *Engineering | Red Hat, Inc.* >>> >>> *[email protected] <[email protected]> | fusesource.com | redhat.com >> * >>> >>> *skype: hiramchirino | twitter: @hiramchirino< >> http://twitter.com/hiramchirino> >>> * >>> >>> *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>* > > > > -- > > ** > > *Hiram Chirino* > > *Engineering | Red Hat, Inc.* > > *[email protected] <[email protected]> | fusesource.com | redhat.com* > > *skype: hiramchirino | twitter: @hiramchirino<http://twitter.com/hiramchirino> > * > > *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>*
