big +1 to being more modular. the tricky bit, and major pain area will be the tests b/c most of the broker tests use the default store or memory store and a bunch of later tests try and validate on all of persistent stores.
It may make sense to have core contain just the memory store and pull all persistent store related tests into a composite store test module that can pull/reference in all of the store implementations. Any tests that are store specific can stay with the relevant module. But in most cases, store tests should be generic and work on all supported implementations (kaha store, am thinking u get left behind) On 1 October 2012 15:18, Hiram Chirino <[email protected]> wrote: > Considering how large the activemq-core module is, I was wondering if you > guys thought it might be beneficial to move the message stores into their > own modules. The leveldb store that is now integrated into the builds > gives us an example of how it can be done while still providing tight > integration /w XBean. The one down side I can think of is that users who > embed ActiveMQ would need to be aware of this change and update their > builds accordingly to avoid breaking. > > > -- > > ** > > *Hiram Chirino* > > *Engineering | Red Hat, Inc.* > > *[email protected] <[email protected]> | fusesource.com | redhat.com* > > *skype: hiramchirino | twitter: @hiramchirino<http://twitter.com/hiramchirino> > * > > *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>* -- http://redhat.com http://blog.garytully.com
