Sounds like you have a bee in your bonnet for some reason Dan, is there
a reason you don't want to follow the Artemis commit workflow?
to be clear, I'm happy to use either approach, I just think we should be
consistent, if you look at the commit tree its completely different from
where your commits start.
Lets have the conversation that Bruce started and improve on whats
there, it is after all its 10 years old and things move on.
Andy
On 09/06/15 16:03, Daniel Kulp wrote:
On Jun 9, 2015, at 10:47 AM, Andy Taylor <[email protected]> wrote:
Dan,
are you implying you are going to bypass the workflow that everyone else is
using and commit directly? shouldnt we be consistent?
That IS being consistent with the workflow that the *ACTIVEMQ* community has
been using for the last 10+ years and has been using with the git repo for the
last 2 years. So yes, I will be using the workflow that the community has
agreed on and been using. Thanks for asking.
Dan
On 09/06/15 15:45, Daniel Kulp wrote:
On Jun 9, 2015, at 10:32 AM, Clebert Suconic <[email protected]> wrote:
It turns out we didn’t have a build setup for that. We do now.
The build I sent you before was a PR build from my own PR. Unless you
set it up somewhere. Did you set up a new build for that?
Yes:
https://builds.apache.org/view/A-D/view/ActiveMQ/job/ActiveMQ-Artemis-Master/
It builds on each commit to the canonical repository.
Dan
On Tue, Jun 9, 2015 at 10:29 AM, Clebert Suconic
<[email protected]> wrote:
Well, I fixed that situation this morning. I *THOUGHT* we had a CI build
that was running on master on all commits. That was the expectation and if
something broke I would have gotten a “this is broken” email within 15 minutes
or so. It turns out we didn’t have a build setup for that. We do now.
I was not being specific about the situation itself.. just finding it
as an example on where the CI build would been useful.
We have a CI build that run on every Pull Request, not on every commit.
We have a daily build but they are not as fast on catching issues.
I'm asking if you could at least send a PR and wait for the build to finish.
How do I do a pull request that doesn’t involve github? I’m not using github
for development.
You really need github for that. You would need a github account
associated with your apache email and send send the PR.
You don't want to use github at all? If you don't want to use github,
then you certainly won't be able to use these tools.
Do you have any issues on using github?
--
Clebert Suconic
http://community.jboss.org/people/[email protected]
http://clebertsuconic.blogspot.com
