Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1787#discussion_r162261691
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1284,7 +1284,7 @@ private boolean checkDuplicateID(final Message
message,
boolean isDuplicate = false;
if (duplicateIDBytes != null) {
- cache = getDuplicateIDCache(message.getAddressSimpleString());
+ cache = getDuplicateIDCache(context.getAddress(message));
--- End diff --
Same as other comment, re making one call to context.getAddress(message)
and re-using the result
---
