Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1787#discussion_r162358705
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1284,7 +1284,7 @@ private boolean checkDuplicateID(final Message
message,
boolean isDuplicate = false;
if (duplicateIDBytes != null) {
- cache = getDuplicateIDCache(message.getAddressSimpleString());
+ cache = getDuplicateIDCache(context.getAddress(message));
--- End diff --
@michaelandrepearce caching here goes beyond the scope here.
I would need to change a lot of signatures to pass an address as a
parameter.. or cache within each method used during routing.
We can do that.. but it goes beyond the scope of this fix.
---
