Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166386744
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -43,6 +44,8 @@ public PageCountPendingImpl(long queueID, long pageID,
int inc) {
long pageID;
+ long size;
--- End diff --
Why would we use -1 and not 0? These values default to 0 because we don't
want the counter to change if the size is not set. If we default to -1 then
the counters will go negative where as if they are 0 when not set then nothing
changes with the counters which is what we want.
---
