Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166401530
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -43,6 +44,8 @@ public PageCountPendingImpl(long queueID, long pageID,
int inc) {
long pageID;
+ long size;
--- End diff --
@michaelandrepearce - did you have in mind having the getter in the class
handle the -1 (ie have the getSize() method check for -1 and return 0 if
negative) or having the getSize() method return the -1 as is and then have the
code using the value explicitly do the check for negative?
---
