[GitHub] activemq-artemis pull request #2093: ARTEMIS-1872 Check for queue exists bef...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2093#discussion_r189859957
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
    @@ -150,6 +150,10 @@ public CharSequence subSequence(final int start, final 
int end) {
           return subSeq(start, end);
        }
     
    +   public static boolean compare(SimpleString s1, SimpleString s2) {
    --- End diff --
    
    you can call it equals as well, `compare` usually is used for `Comparator` 
API-like ie that return a `int` value


---