Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2093#discussion_r189874889
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
---
@@ -150,6 +150,10 @@ public CharSequence subSequence(final int start, final
int end) {
return subSeq(start, end);
}
+ public static boolean compare(SimpleString s1, SimpleString s2) {
--- End diff --
Good point, this isn't even needed, changed to using
java.util.Objects.equals
---
