Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r233205369
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -318,6 +320,33 @@ public synchronized boolean containsProperty(final
SimpleString key) {
}
}
+ public synchronized boolean
cleanupInternalProperties(Predicate<SimpleString> propertyNamePredicate) {
+ if (!internalProperties) {
--- End diff --
I have added a super tiny optimization on `PacketImpl` turning a method
into a static one: using https://github.com/AdoptOpenJDK/jitwatch to read the
compilation logs seems to help the inlining of the method (for free). I would
prefer to maintain separated the optimizations, but a single PR for a single
word change (not a bug fix) seems really too much for me...wdyt?
---
