Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491975
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -1143,20 +1167,17 @@ public Object removeProperty(final String key) {
@Override
public boolean containsProperty(final SimpleString key) {
- checkProperties();
- return properties.containsProperty(key);
+ return checkProperties().containsProperty(key);
}
@Override
public boolean containsProperty(final String key) {
- checkProperties();
- return properties.containsProperty(SimpleString.toSimpleString(key,
getPropertyKeysPool()));
+ return
checkProperties().containsProperty(SimpleString.toSimpleString(key,
getPropertyKeysPool()));
--- End diff --
delegate to:
public boolean containsProperty(final SimpleString key) {
Just repeat this review comment on all methods taking a String key ;) to
delegate to the SimpleString equiv.
---
