Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245095523
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1350,7 +1350,7 @@ public synchronized boolean hasNext() {
return true;
}
- if (!pageStore.isPaging()) {
+ if (!pageStore.isPagingDirtyRead()) {
--- End diff --
Concern here is this ins't an async case.
Btw i cannot see the change in QueueImpl to use the new paging dirty read.
---