michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250761629
########## File path: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java ########## @@ -157,7 +157,12 @@ public NetworkHealthCheck parseURIList(String addressList) { @Override protected ActiveMQThreadFactory getThreadFactory() { - return new ActiveMQThreadFactory("NetworkChecker", "Network-Checker-", false, getThisClassLoader()); Review comment: I'd like to see a test case on this. I think the issue might be we have some ThreadFactories which are not using the ActiveMQThreadFactory which should imo ensure the privileged access if its used in replacement for those, and actually we just need to fix those up. A test though is the best way for sure, so what ever fix, we know its resolved. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services