michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]:
ThreadPoolExecutor leak under SM due to lack of privileged block.
URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java
##########
@@ -157,7 +157,12 @@ public NetworkHealthCheck parseURIList(String
addressList) {
@Override
protected ActiveMQThreadFactory getThreadFactory() {
- return new ActiveMQThreadFactory("NetworkChecker", "Network-Checker-",
false, getThisClassLoader());
Review comment:
I mean we need a test in ActiveMQ Artemis for this to merge.
We need to be able to build, refactor, and release with knowing we haven't
broken something our users and upstream/dependent projects have on us. Like
wise we need to validate the fix.
essentially i suggest a test is created with a security manager on, in the
activemq artemis project, with a similar leak detector to what youre doing in
your project "wildfly" so to create this testing scenario in artemis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
