On Fri, 1 Mar 2019 at 17:25, Clebert Suconic <[email protected]> wrote: > > I would like to propose an Apache ActiveMQ Artemis Native 1.0.0 release. > > This is a sub component of ActiveMQ Artemis Native, > > Source distribution can be found here: > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/1.0.0/ > > Maven repository is here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1178 > > > The source tag: > https://gitbox.apache.org/repos/asf?p=activemq-artemis-native.git;a=tag;h=refs/tags/1.0.0 > > > > Notice this is a sub component of ActiveMQ Artemis, and the release > notes will be part of the main component. And also, the binary here is > distributed through maven. > > > [ ] +1 approve the release as Apache Artemis 2.4.0 > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Here's my +1 > > > -- > Clebert Suconic
Not a vote as I cant try it out at the moment, though its not binding anyway. Just some comments from giving it a quick skim around trivial issues that should be fixed for the release if someone finds a blocking issue: - LICENSE contains some incorrect detail, though for a file that doesnt actually exist in the release. - NOTICE should have the contained name updated to more fully match the release. - The README ordering is a bit off. It initially lists a bunch of dependencies for you to install, then tells you how to build with Docker that presumably means you dont need them installed (but do need Docker, which isnt listed), and then after that goes back to giving manual build instructions where you would need them installed. - The example in the README sets JAVA_HOME to a Java7 install but 8 is required. Robbie
