I would put them outwith the broker repository. Not really because of bloat, which was only a very small part of why I didnt think the proposed Kafka Bridge should live inside the broker repo+package for example, but thats certainly also something to keep in mind given the build is pretty large/slow already.
I wouldnt say a single plugin repository is necessarily a great idea, it can tend to become a bit of a dumping ground for idea-of-the-week, but the main thing for me would be that components should be independently released if there were to be a bunch of optional components with mostly unrelated functionality in the same place (e.g, the ideas mentioned in this thread already seem mostly independent). Robbie On Wed, 29 May 2019 at 11:54, Christopher Shannon <christopher.l.shan...@gmail.com> wrote: > > This sounds good to me, I think it would be good to have some way to keep a > collection of plugins that is easy for people to find. I guess they could > either go into a new directory under the current Artemis build and each > have their own sub module/ jar or they could live by themselves in a new > sub project. > > I'm not really sure which approach would be best. Having new sub modules > makes it easy to keep the plugins in sync with the broker but can bloat the > release with things that may not belong in the main release (which is why > we didn't want the Kafka Bridge to be included as part of the main release) > > Having a new sub project could be nice so people can optionally grab > plugins only if they want them and this would allow the plugins could be > updated and released on their own schedule. The main downside I see with > the sub project approach is trying to keep plugins in sync with the broker > version. If we don't end up bundling the plugins with the broker itself > then we need to figure out how to handle compatibility across releases. > > On Tue, May 28, 2019 at 10:50 PM Justin Bertram <jbert...@apache.org> wrote: > > > With the impending support for metrics plugins [1] as well as other > > pluggable components which have been discussed in the past (e.g. Kafka > > bridge [2] proposed by Mike Pearce) I think it would great to have an > > official place where these things could be hosted and potentially included > > as part of a broker release. Does anybody have any opinion on this? > > > > > > Justin > > > > [1] https://github.com/apache/activemq-artemis/pull/2681 > > [2] https://issues.apache.org/jira/browse/ARTEMIS-1478 > >
